Repository navigation
Refresh signed-commits kata: SSH signing, per-OS setup, exercise - #395
Conversation
…troubleshooting Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
a2ebf50 to
bdeee6a
Compare
There was a problem hiding this comment.
🟡 Changes recommended
SSH-agent setup, GPG format selection, and exercise commands need corrections to prevent signing and commit failures.
3 open findings
What changed in this PR
Updates the signed-commits kata from a Windows-focused GPG guide to cross-platform SSH and GPG instructions.
Changes:
- Recommends SSH signing and expands per-OS GPG setup.
- Adds a hands-on exercise, verification examples, and troubleshooting.
- Lists the kata in the overview.
| File | Description |
|---|---|
| signed-commits/README.md | Expands signing setup, exercises, and verification guidance. |
| Overview.md | Adds the signed-commits kata link. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| If your key has a passphrase, load it into `ssh-agent` so you are not asked on every commit (`ssh-add ~/.ssh/id_ed25519_signing`). | ||
| On macOS, `ssh-add --apple-use-keychain` stores it in the keychain. |
There was a problem hiding this comment.
Updated the SSH setup to require loading the matching private key into a running ssh-agent before signing, regardless of passphrase, and included the custom key filename in the macOS command. Commit: 216e0fe.
| 2. Make a commit **with** signing: `git commit -S -m "signed"` (if you set `commit.gpgsign true` globally, plain `git commit` is enough). | ||
| 3. Compare the two with `git log --show-signature` (see below). Which one has a signature? | ||
| 4. Create a repository on GitHub, push both commits, and look at the commit list in the web UI. | ||
| The signed commit has a green **Verified** badge, the unsigned one has none. | ||
| 5. Try the usual failure: set `git config user.email someone-else@example.com`, make another signed commit and push. |
There was a problem hiding this comment.
Added --allow-empty to the signed commit instructions in steps 2 and 5, including the automatic-signing alternatives. Commit: 216e0fe.
Co-authored-by: JKrag <1712950+JKrag@users.noreply.github.com>

Summary
signed-commitsguide so it works on Windows, macOS and Linux (previously Windows/Gpg4win only).GPG_TTY/pinentry-macgotchas, correctedgpg-agent.confpaths plus agent restart, Windowsgpg.programfix.--globalconfig.git-log-show-signature.png(never committed) with a text example; fix typos and headings.Overview.md.Testing
--keyid-format LONG, signing config, commit,--show-signature) and the SSH flow (gpg.format ssh,allowedSignersFile) on macOS: both give "Good signature".pinentry-macsetup, and the GitHub-side steps (Signing Key type, Verified/Unverified badges). Reviewers on Windows please check the Git Bashgpg.programline and the%APPDATA%\gnupgpath.Tradeoffs
🤖 Generated with Claude Code